Clean Makefile #120
Merged
Clean Makefile #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=====================================
Coverage 3.46% 3.46%
=====================================
Files 10 10
Lines 7555 7555
=====================================
Hits 262 262
Misses 7283 7283
Partials 10 10 ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Jan 20, 2025
adityachopra29
force-pushed
the
cleanup
branch
from
fcce023 to
72fd7bd
Compare
yurishkuro
reviewed
Jan 20, 2025
yurishkuro
reviewed
Jan 20, 2025
| ${PROTO_GEN_PYTHON_DIR_POLYGLOT} \ | ||
| ${PROTO_GEN_JS_DIR_POLYGLOT} \ | ||
| ${PROTO_GEN_CPP_DIR_POLYGLOT} \ | ||
| ${PROTO_GEN_CSHARP_DIR_POLYGLOT} | ||
|
|
||
| .PHONY: proto-prepare | ||
| proto-prepare: |
There was a problem hiding this comment.
group real vs. transient generation targets together, right now they are mixed
There was a problem hiding this comment.
I have a doubt here... aren't they seperated now? The transient generations are in .proto-gen-polyglot dir, and the real generations are in the proto-gen/ dir.
|
@adityachopra29 do you have a commit you need to push? |
Signed-off-by: adityachopra29 <[email protected]>
Signed-off-by: adityachopra29 <[email protected]>
Signed-off-by: adityachopra29 <[email protected]>
Signed-off-by: adityachopra29 <[email protected]>
Signed-off-by: adityachopra29 <[email protected]>
Signed-off-by: adityachopra29 <[email protected]>
adityachopra29
force-pushed
the
cleanup
branch
from
7cf84f7 to
afece2f
Compare
|
Yes. I was/am travelling today .... so wasnt able to respond earlier....will take care next time. Have pushed the changes now. |
yurishkuro
approved these changes
Jan 21, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
How was this change tested?
Description of the changes
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test