Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyValuesTable]: replace defaultProps with destructuring #2666

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

its-me-abhishek
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Removed defaultprops from KeyValuesTable

How was this change tested?

  • npm ci
  • npm test

Checklist

@its-me-abhishek its-me-abhishek requested a review from a team as a code owner February 14, 2025 10:21
@its-me-abhishek its-me-abhishek requested review from pavolloffay and removed request for a team February 14, 2025 10:21
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (df2cfe8) to head (2782424).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2666      +/-   ##
==========================================
- Coverage   96.62%   96.62%   -0.01%     
==========================================
  Files         256      256              
  Lines        7733     7732       -1     
  Branches     1945     2018      +73     
==========================================
- Hits         7472     7471       -1     
  Misses        261      261              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@its-me-abhishek its-me-abhishek changed the title fix: remove defaultProps from KeyValuesTable [KeyValuesTable]: replace defaultProps with destructuring Feb 14, 2025
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Feb 14, 2025
@yurishkuro yurishkuro added this pull request to the merge queue Feb 14, 2025
@yurishkuro
Copy link
Member

The issue mentions KeyValuesText instead of KeyValuesTable, was it a typo?

Merged via the queue into jaegertracing:main with commit cc7ba5a Feb 14, 2025
9 of 10 checks passed
@its-me-abhishek
Copy link
Contributor Author

yes 😅 Reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants