[WIP] Implement spans exporting for ClickHouse storage in Jaeger V2

[haanhvu]

Which problem is this PR solving?

Part of #5058

[haanhvu]

@yurishkuro This still needs some supplements and a lot of cleanups and tests. I'm still working on them. But could you take an initial look to see if I'm going the right way? Thanks!

[k0zl]

👍 I've been waiting clickhouse support for a long time. Is there anything I can help you with?

[haanhvu]

👍 I've been waiting clickhouse support for a long time. Is there anything I can help you with?

@k0zl Sure! For this PR (spans exporting), the remaining parts are:

• Finish schema implementation in plugin/storage/clickhouse/spanstore/schema.go. We described our schema choices in our benchmark report. As you can see in the current schema.go, I just implemented the spans table, not the materialized views yet.
• Add tests: I'm pushing an unit factory_test.go this week. There are other unit tests, e2e test, or even local test with Jaeger v2 binary to do. (Jaeger v2 issue/decription is here)

After finishing with spans exporting, we'll move to spans reading,...

Also, since clickhouse storage is supported in Jaeger v2, to make this realeased you could also help with Jaeger v2 roadmap, in the issue I linked above.

Please choose whatever interests you. Thanks!

[yurishkuro]

@haanhvu it would be useful to write a design doc / roadmap documenting what we're doing and what tasks need to be done, are you up for that? You can model it after the Jaeger V2 document.

[haanhvu]

@haanhvu it would be useful to write a design doc / roadmap documenting what we're doing and what tasks need to be done, are you up for that? You can model it after the Jaeger V2 document.

Yeah I'll create an issue for supporting clickhouse in jaeger v2 tomorrow

[codecov]

Codecov Report

Attention: Patch coverage is 33.11688% with 103 lines in your changes missing coverage. Please review.

Project coverage is 95.78%. Comparing base (1c1bc08) to head (e0e69ad).
Report is 174 commits behind head on main.

Files with missing lines	Patch %	Lines
plugin/storage/clickhouse/spanstore/exporter.go	0.00%	59 Missing ⚠️
plugin/storage/clickhouse/factory.go	40.90%	10 Missing and 3 partials ⚠️
plugin/storage/clickhouse/config.go	58.62%	6 Missing and 6 partials ⚠️
...ger/internal/exporters/storageexporter/exporter.go	33.33%	3 Missing and 3 partials ⚠️
...eger/internal/extension/jaegerstorage/extension.go	80.76%	3 Missing and 2 partials ⚠️
.../extension/jaegerstorage/factoryadapter/factory.go	0.00%	5 Missing ⚠️
plugin/storage/clickhouse/spanstore/schema.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4941      +/-   ##
==========================================
- Coverage   96.38%   95.78%   -0.60%     
==========================================
  Files         329      333       +4     
  Lines       16060    16199     +139     
==========================================
+ Hits        15479    15517      +38     
- Misses        404      492      +88     
- Partials      177      190      +13     

Flag	Coverage Δ
badger_v1	8.04% <ø> (ø)
badger_v2	1.89% <0.00%> (-0.04%)	⬇️
cassandra-3.x-v1	16.60% <ø> (ø)
cassandra-3.x-v2	1.81% <0.00%> (-0.04%)	⬇️
cassandra-4.x-v1	16.60% <ø> (ø)
cassandra-4.x-v2	1.81% <0.00%> (-0.04%)	⬇️
elasticsearch-7.x-v1	18.88% <ø> (ø)
elasticsearch-8.x-v1	19.07% <ø> (ø)
elasticsearch-8.x-v2	19.08% <ø> (ø)
grpc_v1	9.47% <ø> (ø)
grpc_v2	7.35% <0.00%> (-0.14%)	⬇️
kafka	9.76% <ø> (ø)
opensearch-1.x-v1	18.93% <ø> (ø)
opensearch-2.x-v1	18.93% <ø> (ø)
opensearch-2.x-v2	18.92% <ø> (ø)
unittests	93.66% <33.11%> (-0.58%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[haanhvu]

@yurishkuro Could you take a look at the failed all-in-one build? make all-in-one-integration-test passed locally for me. Not sure why it fails in CI.

[yurishkuro]

I am seeing error

Error: failed to build pipelines: failed to create "jaeger_storage_exporter" exporter for data type "traces": nil PushTraces
2023/12/29 16:57:59 failed to build pipelines: failed to create "jaeger_storage_exporter" exporter for data type "traces": nil PushTraces
+ exit 1

[haanhvu]

I am seeing error

Error: failed to build pipelines: failed to create "jaeger_storage_exporter" exporter for data type "traces": nil PushTraces
2023/12/29 16:57:59 failed to build pipelines: failed to create "jaeger_storage_exporter" exporter for data type "traces": nil PushTraces
+ exit 1

@yurishkuro This error didn't come up in my make all-in-one-integration-test. Probably because my make all-in-one-integration-test checked v1, not v2? How to make sure this command checks v2?

[yurishkuro]

This error didn't come up in my make all-in-one-integration-test

This test doesn't just run on its own, it expects the binary running, so how are you starting the binary?

For example, this works:

# terminal 1
$ go run -tags=ui ./cmd/jaeger

# terminal 2
$ SKIP_SAMPLING=true make all-in-one-integration-test

But this is running with default aio config for OTEL, whereas you need to provide your own config in order to test the same against CH.

[haanhvu]

go run -tags=ui ./cmd/jaeger

Ah, I ran the binary with make run-all-in-one... That's why v2 wasn't checked... Let me try again.

[haanhvu]

But this is running with default aio config for OTEL, whereas you need to provide your own config in order to test the same against CH.

The nil Pushtraces error with default aio config has been resolved.

So now I'll have to run clickhouse server, make my own jaeger v2 config (that exports to clickhouse) and go run -tags=ui ./cmd/jaeger --config=config.yaml right? I'll try it tomorrow.

[github-actions]

Test Results

2 054 tests  +2   2 044 ✅ +2   1m 9s ⏱️ ±0s
  221 suites +2      10 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit f7c95ed. ± Comparison against base commit d489e3a.

♻️ This comment has been updated with latest results.

[haanhvu]

@yurishkuro I ran the binary with my config.yaml, spans were exported successfully to clickhouse:

Should we add an e2e test now, or wait until spans reading are implemented?

Also, can you check the unit tests? I just have one factory_test.go, no test files for config.go or spanstore because factory already calls config and spanstore.

Pls check if there's anything else you think we should test in this PR.

[yurishkuro]

Should we add an e2e test now, or wait until spans reading are implemented?

You wouldn't be able to do e2e without reading, that's how the tests verify that traces are saved.

[haanhvu]

@yurishkuro I rebased and made a little change following what we're having with other V2 storage. I checked the change locally and it worked:

There's one goleak failure in unit tests. However, the goleak failure is in database/sql package, not our code. Should we ignore or do what with this?

Also, the code coverage is a bit skewed. Seems like codecov checks per file or per package and crossed-files and cross-packages function calls are not counted. Do you want to rearrange the files/packages so that code coverage is more accurate?

[yurishkuro]

There's one goleak failure in unit tests. However, the goleak failure is in database/sql package, not our code. Should we ignore or do what with this?

We shouldn't ignore leaks. Most likely it's from not closing resources in tests properly, you can see which goroutine is remaining running and understand where it starts. There are rare cases where libraries introduce unsolvable leaks (like glog), but I am skeptical database/sql would be such lib.

The codecov for storage is usually combined from unit tests and e2e tests.

Note that V2 Storage API already exists, and we have an adapter to v1 that will be used by the jaegerexporter. The Clickhouse implementation can be the first one to be natively supporting V2.

[haanhvu]

Note that V2 Storage API #5497, and we have an adapter to v1 that will be used by the jaegerexporter. The Clickhouse implementation can be the first one to be natively supporting V2.

Yeah I saw the conflicts in exporter.go. I'll rebase and make the current implementation work with the rebase first, then make clickhouse v2-native next.

[haanhvu]

The latest rebased implementation works (not v2-native yet)