Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add esmapping-generator into jaeger binary #6327

Merged
merged 5 commits into from
Jan 23, 2025

Remove es

757b117
Select commit
Loading
Failed to load commit list.
Merged

feat: Add esmapping-generator into jaeger binary #6327

Remove es
757b117
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 22, 2025 in 0s

96.23% (target 95.00%)

View this Pull Request on Codecov

96.23% (target 95.00%)

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (04b1ea4) to head (757b117).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...mapping-generator/generator/esmapping_generator.go 66.66% 2 Missing and 1 partial ⚠️
internal/storage/elasticsearch/mapping/command.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6327      +/-   ##
==========================================
- Coverage   96.23%   96.23%   -0.01%     
==========================================
  Files         373      377       +4     
  Lines       21406    21421      +15     
==========================================
+ Hits        20600    20614      +14     
  Misses        614      614              
- Partials      192      193       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov