[chore] Move es/spanstore/dbmodel to internal directory #6428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zzzk1 <[email protected]>
|
another change here: open-telemetry/opentelemetry-collector-contrib#36972 |
zzzk1
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6428 +/- ##
==========================================
- Coverage 96.27% 96.25% -0.02%
==========================================
Files 368 368
Lines 21008 21008
==========================================
- Hits 20225 20222 -3
- Misses 599 601 +2
- Partials 184 185 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: zzzk1 <[email protected]>
zzzk1
changed the title
yurishkuro
approved these changes
Dec 27, 2024
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 5, 2025
…g#6428) - Resolves jaegertracing#6410 - Prerequisite: open-telemetry/opentelemetry-collector-contrib#36972 - move plugin/storage/es/spanstore/dbmodel to plugin/storage/es/spanstore/internal/dbmodel - - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: zzzk1 <[email protected]>
andrzej-stencel
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jan 7, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Copy the Jaeger plugin/storage/es/spanstore/dbmodel for logzioexporter, and remove the dependency. The dbmodel package in Jaeger will be internal from v1.65 (jaegertracing/jaeger#6428). <!-- Issue number (e.g. #36970) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes #36970 <!--Describe what testing was performed and which tests were added.--> #### Testing Covered by existing <!--Describe the documentation added.--> <!--Please delete paragraphs that you did not use before submitting.-->
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…36972) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Copy the Jaeger plugin/storage/es/spanstore/dbmodel for logzioexporter, and remove the dependency. The dbmodel package in Jaeger will be internal from v1.65 (jaegertracing/jaeger#6428). <!-- Issue number (e.g. open-telemetry#36970) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36970 <!--Describe what testing was performed and which tests were added.--> #### Testing Covered by existing <!--Describe the documentation added.--> <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test