Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage]Upgraded integration tests to use Dependency Writer of storage_v2 #6559

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

Manik2708
Copy link
Contributor

Which problem is this PR solving?

Fixes a part of: #6366

Description of the changes

  • Upgared the integration tests

How was this change tested?

  • e2e tests

Checklist

@Manik2708 Manik2708 requested a review from a team as a code owner January 17, 2025 09:59
@Manik2708 Manik2708 requested a review from jkowall January 17, 2025 09:59
@Manik2708
Copy link
Contributor Author

I am little confused on the usage of DependencyWriter. It is not a part of Factory and only used in integration tests. So should it be implemented in storage_v2? Also there are no mocks of Writer in storage of v1, hence not able to write unit test for it. This is expected because currently it is only used in e2e tests.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (aa7cf7d) to head (f918ce0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6559      +/-   ##
==========================================
+ Coverage   96.21%   96.24%   +0.02%     
==========================================
  Files         373      373              
  Lines       21400    21406       +6     
==========================================
+ Hits        20591    20602      +11     
+ Misses        616      612       -4     
+ Partials      193      192       -1     
Flag Coverage Δ
badger_v1 10.64% <0.00%> (-0.01%) ⬇️
badger_v2 2.77% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1-manual 16.58% <100.00%> (+0.04%) ⬆️
cassandra-4.x-v2-auto 2.71% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2-manual 2.71% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1-manual 16.58% <100.00%> (+0.04%) ⬆️
cassandra-5.x-v2-auto 2.71% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2-manual 2.71% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 20.36% <100.00%> (+0.03%) ⬆️
elasticsearch-7.x-v1 20.44% <100.00%> (+0.04%) ⬆️
elasticsearch-8.x-v1 20.59% <100.00%> (+0.04%) ⬆️
elasticsearch-8.x-v2 2.77% <0.00%> (+<0.01%) ⬆️
grpc_v1 12.16% <0.00%> (-0.01%) ⬇️
grpc_v2 9.02% <0.00%> (-0.01%) ⬇️
kafka-3.x-v1 10.32% <0.00%> (-0.01%) ⬇️
kafka-3.x-v2 2.77% <0.00%> (-0.01%) ⬇️
memory_v2 2.77% <0.00%> (+<0.01%) ⬆️
opensearch-1.x-v1 20.48% <100.00%> (+0.04%) ⬆️
opensearch-2.x-v1 20.48% <100.00%> (+0.04%) ⬆️
opensearch-2.x-v2 2.76% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.51% <0.00%> (-0.01%) ⬇️
unittests 95.09% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Manik2708 Manik2708 changed the title [storage_v2]Upgraded integration tests to use Dependency Writer of storage_v2 [storage]Upgraded integration tests to use Dependency Writer of storage_v2 Jan 17, 2025
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jan 18, 2025
@yurishkuro yurishkuro enabled auto-merge (squash) January 18, 2025 00:50
@yurishkuro yurishkuro merged commit b04e0ba into jaegertracing:main Jan 18, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage changelog:ci Change related to continuous integration / testing v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants