feat: add dependency processor using Apache Beam #6560
+336
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yunmaoQu <[email protected]>
yunmaoQu
force-pushed
the
add-dependency-processor
branch
from
af5f794 to
60fb334
Compare
yurishkuro
reviewed
Jan 17, 2025
| perTenant: make(map[string]*Tenant), | ||
| defaultConfig: cfg, | ||
| perTenant: make(map[string]*Tenant), | ||
| useNewDependencies: false, // 添加初始化 |
There was a problem hiding this comment.
please use English in comments
yurishkuro
reviewed
Jan 17, 2025
| // Copyright (c) 2025 The Jaeger Authors. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package dependencyprocessor |
There was a problem hiding this comment.
if this is placed under /processors/ is needs to follow the OTEL Processor framework patterns, like having a factory, etc.
yurishkuro
reviewed
Jan 17, 2025
I will fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #5911
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test