-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the use of ahash as the default hasher for more then redis. #171
Conversation
I did a very basic performance comparason using the fib example, using
|
@jaemk anything else that has to be done to merge this PR? |
Cargo.toml
Outdated
@@ -18,6 +18,7 @@ rustdoc-args = ["--cfg", "docsrs"] | |||
[features] | |||
default = ["proc_macro"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it should be the default hasher or not. @jaemk ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho, I see little downsides using this as default.
@FilipAndersson245 sorry for the delay, thank you for adding this! I'll merge and release later today |
no problem 😄 |
I'm on board with making it the default hash algo. Can you also update the crate-level docs explaining that it's the default |
done |
@FilipAndersson245 would you mind running |
dc053a1
to
c198363
Compare
Hello had to do some rebasing of the commits everything should be fine now I believe. |
This PR adds a new feature
ahash
that changes primarily what hashing algorithm is used to hash data, instead opting for the fasterahash
algorithm. It also changes the hashtable implementation instead to be directly depending onhashbrown
for sized we already depended directly onhashbrown
so there the only change is theahash
hashing compared to the default. The default inhashbrown
is to useahash
so for the other ones I opted just to usehashbrown
directly. Maybe this could even be simplified as we could usehashbrown
everywhere.✅cargo fmt
✅update changelog