Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a pretty difficult-to-reproduce scenario where the interleaving code would get 'stuck' following line
crunker/src/crunker.ts
Line 407 in 0ac03d4
input.getChannelData()
potentially for millions of data in each audio channel.I made the change to make this call only N times where N = number of channels and store the channel data in an array instead.
This PR also includes an early return in the interleaving code for scenarios where there's a single channel buffer which saves some memory and improves performance.