Adding Energy consumption sensors #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add compiled Python files to .gitignore * Run rego1000dump on esp32-evb * Run rego1000 on ESP32-EVB * Update spellcheck settings * Add compiled Python files to .gitignore * Add rego1000 v3.14 variables * Temporary remove sensors creating errors * Merge branch 'rego1000-3.14' into local_adaptation * Added back missing REGO_CAN_SUFFIX
|
Whops... sorry... seems the PR included some of my local settings in the Rego1000.yaml |
|
I realize it's even more of my local changes that were included, do not know why... not sure I know how to fix without closing the PR |
…n that has only been added to v3.14.0.
|
Now the diff looks OK, it's only the changes I intended to submit. And the smoke test runs cleanly so I you think those additions adds any value you are free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are interested to add more sensor examples...
If not - just discard...