Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JMS Standalone TCK test refactor with Junit. #1185

Merged
merged 3 commits into from
Jun 27, 2024
Merged

JMS Standalone TCK test refactor with Junit. #1185

merged 3 commits into from
Jun 27, 2024

Conversation

gurunrao
Copy link
Contributor

@gurunrao gurunrao commented Jul 16, 2023 •
edited
Loading

JMS Standalone TCK test refactor with Junit and arquillian.

Standalone Test results:

The CI run for the refactored can be found at: https://ci.eclipse.org/jakartaee-tck/job/guru/job/jakarta-jms-standalone-tck-glassfish/3/console

The test logs can be found at: https://ci.eclipse.org/jakartaee-tck/job/guru/job/jakarta-jms-standalone-tck-glassfish/3/artifact/glassfish-runner/jms-tck/target/failsafe-reports/

Test run summary: Tests run: 903, Failures: 0, Errors: 2, Skipped: 0

Pending Tasks:

  • JMS Platform TCK tests
  • JMS Signature Test
  • Resolution of 2 Test errors for Standalone TCK.

@gurunrao
Copy link
Contributor Author

gurunrao commented Aug 1, 2023 •
edited
Loading

3 failures with following exceptions:
com.sun.ts.tests.jms.core.appclient.txqueuetests.�[1mTxQueueTestsIT�[m [�[1;34mINFO�[m] Running com.sun.ts.tests.jms.core.appclient.txtopictests.�[1mTxTopicTestsIT�[m java.lang.ClassCastException: class com.sun.messaging.jmq.jmsclient.BytesMessageImpl cannot be cast to class jakarta.jms.TextMessage (com.sun.messaging.jmq.jmsclient.BytesMessageImpl and jakarta.jms.TextMessage are in unnamed module of loader 'app') at com.sun.ts.tests.jms.core.appclient.txtopictests.TxTopicTestsIT.transactionRollbackOnPublishTopicTest(TxTopicTestsIT.java:465)
the code which is causing exception is https://github.com/gurunrao/jakartaee-tck/blob/tckrefactor-jms/jms/src/main/java/com/sun/ts/tests/jms/core/appclient/txtopictests/TxTopicTestsIT.java#L465 , code is same as before refactor.

@gurunrao gurunrao marked this pull request as ready for review August 23, 2023 12:14
@gurunrao gurunrao changed the title JMS Standalone TCK test refactor with Junit and arquillian. JMS Standalone TCK test refactor with Junit. Dec 8, 2023
@gurunrao
Copy link
Contributor Author

@scottmarlow - any recommendation for reviewers of the PR from messaging spec team?

@scottmarlow
Copy link
Contributor

@scottmarlow - any recommendation for reviewers of the PR from messaging spec team?

Yes, I just opened the https://jakarta.ee/specifications/messaging page which links to the Messaging spec project https://projects.eclipse.org/projects/ee4j.messaging and click on the who is involved tab https://projects.eclipse.org/projects/ee4j.messaging/who:

@dblevins is the lead of Messaging
@arjantijms is a committer
Others as well under there, I gotta join a call now but you see the idea of how to find who to include. You can also always send email to the messaging dev ml.

@gurunrao
Copy link
Contributor Author

@scottmarlow - any recommendation for reviewers of the PR from messaging spec team?

Yes, I just opened the https://jakarta.ee/specifications/messaging page which links to the Messaging spec project https://projects.eclipse.org/projects/ee4j.messaging and click on the who is involved tab https://projects.eclipse.org/projects/ee4j.messaging/who:

@dblevins is the lead of Messaging @arjantijms is a committer Others as well under there, I gotta join a call now but you see the idea of how to find who to include. You can also always send email to the messaging dev ml.

thanks @scottmarlow that helps.

@gurunrao gurunrao requested review from dblevins and arjantijms May 15, 2024 13:33
@arjantijms
Copy link
Contributor

I've been doing some initial looking at the files, and so far it looks good.

@gurunrao
format and organize imports.
a99b8e8 
Signed-off-by: Gurunandan Rao <[email protected]>
@gurunrao gurunrao merged commit fbb2fb9 into jakartaee:tckrefactor Jun 27, 2024
1 of 2 checks passed
starksm64 pushed a commit to jakartaredhat/platform-tck-refactor that referenced this pull request Jul 14, 2024
@gurunrao @starksm64
JMS Standalone TCK test refactor with Junit. (jakartaee#1185)
f818343 
* jms code refactor.

Signed-off-by: Gurunandan Rao <[email protected]>

* rename client files with IT suffix and other changes.

Signed-off-by: Gurunandan Rao <[email protected]>

* format and organize imports.

Signed-off-by: Gurunandan Rao <[email protected]>

---------

Signed-off-by: Gurunandan Rao <[email protected]>
@gurunrao gurunrao deleted the tckrefactor-jms branch September 26, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alwin-joseph alwin-joseph alwin-joseph left review comments

@dblevins dblevins Awaiting requested review from dblevins

@arjantijms arjantijms Awaiting requested review from arjantijms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gurunrao @scottmarlow @arjantijms @alwin-joseph