-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSTL TCK Refactoring using Arquillian and JUnit #1203
JSTL TCK Refactoring using Arquillian and JUnit #1203
Conversation
- use create-jvm-options to set properties - add missed out property files to jstlTCKCommonJar
@scottmarlow @alwin-joseph - IMO, we should continue with review and merge of the PR, since same changes will be helpful for Platform TCK EE 11 release. |
@alwin-joseph - Please test with latest GF 8 version + JDK21. |
My analysis: Total tests : 538
I suggest the test failures be addressed in separate change if possible. jakartaee/tags#255 reports several JDK related issues for Tags TCK. Those fixes can be applied to the refactored source. |
I like that this pull request kept the same TCK test package name as it was with EE 10. I meant to mention that it is harder to automate the refactoring when we change the test class or package names (we can hack around that with package mapping but that will be kind of tedious). Not related to this pr but the latest automation changes are in: https://github.com/scottmarlow/jakartaee-tck/tree/rewritejpahttps://github.com/scottmarlow/jakartaee-tck-tools/tree/rewritejpa tck-rewrite folder + jar2shrinkwrap folder. https://github.com/scottmarlow/jakartaee-tck/tree/rewritejpa doesn't have the output of the ^ changes but I can probably push a sample of those changes to a different branch. |
82 failures are more than expected when compared to challenges for JDK failures at jakartaee/tags#255 and jakartaee/tags#256. It will be great if we can identify and notify glassfish team on the failures which are not part of challenges, so that we know the root cause of the failures. |
Agree. Hopefully those can be tracked on a separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for PR @alwin-joseph. Please create a tracking issue for GF 8 failures, which are not part of challenges open/accepted.
Related Issue(s)
#1126
Describe the change
Pending items :