Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages TCK compliance with pages 4.0 and EL 6.0 apis #1218

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

alwin-joseph
Copy link
Contributor

@alwin-joseph alwin-joseph commented Jan 17, 2024

Describe the change

Changes to build the Pages TCK with latest APIs Pages 4.0 and EL 6.0.

  • Delete the testing of removed methods from JSP 4.0 (elexception, elparseexception, expression, expressionevaluator , variableresolver)
  • Avoid usage of removed getFeatureDescriptors() method in EL 6.0
  • Replace jakarta.servlet.jsp.el.ELException with jakarta.el.ELException
  • Delete the removed classes jakarta.servlet.jsp.el.ExpressionEvaluator & jakarta.servlet.jsp.el.VariableResolver from JSP4.0
  • Delete usage of FunctionMapper
  • Delete tests pageContextGetExpressionEvaluatorTest, pageContextGetVariableResolverTest and jspExceptionGetRootCauseTest
  • Replace getRootCause() with getCause() for JspException class

Pending/TODO for staging Pages TCK:

  • To update the documentation wrt the latest api and refactored TCK.
  • Add standalone signature test

Additional context
Referred the PR jakartaee/pages#234 that removed the deprecated api methods.

cc @markt-asf @gurunrao @arjantijms

@alwin-joseph alwin-joseph marked this pull request as draft January 18, 2024 18:37
@alwin-joseph alwin-joseph marked this pull request as ready for review January 18, 2024 19:09
@alwin-joseph alwin-joseph merged commit 6e0515d into jakartaee:tckrefactor Jan 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants