Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1233 partial fix #1234

Merged

Conversation

markt-asf
Copy link
Contributor

Fixes Issue
Partially fixes #1233

Describe the change

  • removes tests for removed API elements
  • fixes one test that I don't know how it ever passed
  • Updates the JSP API signatures to the latest milestone release (4.0.0-M2)
  • Switches to use the Servlet TCK from the Servlet project

Additional context
None

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow

Copy link
Contributor

@alwin-joseph alwin-joseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[INFO] Tests run: 682, Failures: 0, Errors: 0, Skipped: 0
The changes work, pass with Glassfish8

@alwin-joseph alwin-joseph merged commit d151787 into jakartaee:tckrefactor Mar 2, 2024
1 of 2 checks passed
@markt-asf markt-asf deleted the issue-1233-partial-fix branch March 11, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants