Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user guides to the main build #1235

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

lukasj
Copy link
Contributor

@lukasj lukasj commented Mar 1, 2024

This adds applicable UGs to the main build.

It also:

  • moves platform UG to user_guides/platform
  • adds a layer plugging UGs into the main build (each UG can be easily added/moved/removed around as long the UG parent is reachable somewhere)
  • allows UG parent to become sort of bom-style pom which can live on its own

@scottmarlow with this there will be no need for an extra command to build UGs. I was considering to put this into some profile, but decided to leave this up to your preference

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow

@scottmarlow
Copy link
Contributor

I like it, thanks @lukasj

<version>11.0.0-SNAPSHOT</version>
<relativePath>parent/pom.xml</relativePath>
<artifactId>project</artifactId>
<version>10.0.0-SNAPSHOT</version>
Copy link
Contributor

@scottmarlow scottmarlow Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we still have a lot of 10.0.0-SNAPSHOT references. I was just thinking that since we have already started adding EE 11 tests for the SPEC Ballots, we may as well shift ahead to 11.0.0-SNAPSHOT but that doesn't have to be done in this pull request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #1236

@scottmarlow scottmarlow merged commit da90b3c into jakartaee:tckrefactor Mar 1, 2024
1 of 2 checks passed
@lukasj lukasj deleted the bug branch March 1, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants