TCK UG updates - apply the theme to PDF, add Jakarta EE logo to its front page #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete obsolete version Signed-off-by: Lukas Jungmann <[email protected]>
add the logo to the front page Signed-off-by: Lukas Jungmann <[email protected]>
Signed-off-by: Lukas Jungmann <[email protected]>
scottmarlow
approved these changes
Mar 5, 2024
|
Around 3 hours so far running the Servlet TCK. Perhaps we should only run a few Servlet tests instead of all Servlet TCK tests. |
|
earlier run was ok, see: https://github.com/jakartaee/platform-tck/actions/runs/8155416656 |
|
and the only change between those two runs is this, so unrelated to the test run itself |
|
Hmm, the successful run only took 40 minutes. I wonder if we exceeded some quota. |
|
Merging as the Servlet TCK job might be stuck or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
the
jakartaee-theme.ymlnot being appliedRelated Issue(s)
none
Describe the change
jakartaee-theme.ymlso the PDF generation is successful and the PDF itself is actually readablejakartaee-theme.ymlto the Persistence TCK UG (...and actually fix other UGs, including the platform one, as well).gitignore(add.DS_Store,test.properties,**/**/toc.adoc)Additional context
the
jakartaee-theme.ymlwhile being present in sources, has never been applied; the PDF versions of the spec documents contains the Jakarta EE logo, therefore I believe the logo should be present also in the PDF version of the TCK UG.The thing I'm not sure about is whether the EF logo should be included in the PDF document and if so, then where - but that can be done through the different PR
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow