Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add ear lib to appclient classpath #1653

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Add ability to add ear lib to appclient classpath #1653

merged 1 commit into from
Nov 19, 2024

Conversation

starksm64
Copy link
Contributor

Fixes Issue
#1650

Describe the change
This adds a ${clientEarLibClasspath} variable that can be added to the appclient arquillian.xml in either the clientCmdLineString or clientEnvString appclient protocol configuration settings.

Additional context

with this change the com.sun.ts.tests.assembly.classpath.appclient.Client passes:

starksm@Scotts-Mac-Studio assembly-tck % mvn -Dit.test=com.sun.ts.tests.assembly.classpath.appclient.Client integration-test
[INFO] Cache configuration is not available at configured path /Users/starksm/Dev/Jakarta/platform-tck/.mvn/maven-build-cache-config.xml, cache is enabled with defaults
[INFO] Using XX hash algorithm for cache
[INFO] Scanning for projects...
...
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0

There still are several other failures.

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow

@starksm64 starksm64 linked an issue Nov 19, 2024 that may be closed by this pull request
@gurunrao gurunrao merged commit d9ddf63 into main Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to add library from archive to CP in appclient test
3 participants