Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate ts.home from Maven to Arquillian Tests in Glassfish Messaging Runner #1719

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

aubi
Copy link
Contributor

@aubi aubi commented Dec 23, 2024

Fixes Issue
When running messaging TCK in the glassfish runner, some tests reported this error:

java.lang.IllegalStateException: java.io.FileNotFoundException: ${ts.home}/bin/certificates/clientcert.jks (No such file or directory)

Describe the change
The problem was in unresolved ts.home. This PR adds it to the test from Maven variable to the test system properties.

The total amount of errors decreased from 1932 to 1494. Old summary:

    <completed>3510</completed>
    <errors>1932</errors>
    <failures>0</failures>
    <skipped>0</skipped>

vs after this change (including the previous clean up PR):

    <completed>3510</completed>
    <errors>1494</errors>
    <failures>0</failures>
    <skipped>0</skipped>

Additional context
Just run mvn clean install in platform-tck/glassfish-runner/messaging-platform-tck. I used Java 21.

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow

@arjantijms arjantijms added this to the 11.0 milestone Dec 24, 2024
@arjantijms arjantijms merged commit 1407b95 into jakartaee:main Dec 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants