Test PR 1.1

.clang-tidy

@@ -1,8 +1,8 @@
 ---
-Checks:          '-*,clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,google-*,-google-readability-todo,-google-runtime-references,-google-default-arguments,-clang-analyzer-core.uninitialized.UndefReturn,-clang-analyzer-core.UndefinedBinaryOperatorResult,-clang-analyzer-optin.cplusplus.VirtualCall'
+Checks: '-*,clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,google-*,-google-readability-todo,-google-runtime-references,-google-default-arguments'
 WarningsAsErrors: '*'
 HeaderFilterRegex: '.*'
-FormatStyle:     file
+FormatStyle: file
 ...
 
 # Disable Checks
@@ -14,5 +14,3 @@ FormatStyle:     file
 # clang-analyzer-core.uninitialized.UndefReturn - Generates errors in ACE, how do we ignore?
 # clang-analyzer-core.UndefinedBinaryOperatorResult - Generates errors in ACE, how do we ignore?
 
-# TEMP
-# clang-analyzer-optin.cplusplus.VirtualCall

BUILDING.md

@@ -1,6 +1,7 @@
 # Building
 
 ## Prerequisites (All Platforms)
+
 * [CMake 3.12](https://cmake.org/) or newer
 * C++11 compiler *(see platform specific requirements)*
 * [Doxygen 1.8.11 or greater](https://sourceforge.net/projects/doxygen/) *(for building source documentation)*
@@ -17,13 +18,13 @@
 * [Mac OS X](#mac-os-x)
 * [Solaris](#solaris)
 
-
 ## Setting Path to Geode
+
 Building requires access to an installation of Geode. There are two ways to achieve this:
 
 * Set an environment variable called `GEODE_HOME` that points to your Geode installation path.
 * Pass in `GEODE_ROOT` during the CMake configuration step.
-  * e.g.  add `-DGEODE_ROOT=/path/to/geode` to the _initial_ `cmake` execution command.
+    * e.g. add `-DGEODE_ROOT=/path/to/geode` to the _initial_ `cmake` execution command.
 
 ## Steps to build
 
@@ -36,16 +37,25 @@ $ cmake .. <platform-specific generator parameters (see below)>
 # build step
 $ cmake --build . -- <platform-specific parallelism parameters (see below)>
 ```
-If OpenSSL is installed in a custom location, then you  must pass `OPENSSL_ROOT_DIR` during the CMake configuration step. For example, `-DOPENSSL_ROOT_DIR=/path/to/openssl`.
 
-To explicitly specify the location in which the Native Client will be installed, add `-DCMAKE_INSTALL_PREFIX=/path/to/installation/destination` to this initial `cmake` execution command.
+If OpenSSL is installed in a custom location, then you must pass `OPENSSL_ROOT_DIR` during the CMake configuration step.
+For example, `-DOPENSSL_ROOT_DIR=/path/to/openssl`.
+
+To explicitly specify the location in which the Native Client will be installed,
+add `-DCMAKE_INSTALL_PREFIX=/path/to/installation/destination` to this initial `cmake` execution command.
 
-To set the version header on the API docs, specify PRODUCT_VERSION on the configuration command line. For example, `-DPRODUCT_VERSION=1.2.3`.
+To set the version header on the API docs, specify PRODUCT_VERSION on the configuration command line. For
+example, `-DPRODUCT_VERSION=1.2.3`.
 
 ### Generator
-CMake uses a "generator" to produce configuration files for use by a variety of build tools, e.g., UNIX makefiles, Visual Studio projects. By default a system-specific generator is used by CMake during configuration. (Please see [the CMake documentation](https://cmake.org/documentation/) for further information.) However, in many cases there is a better choice.
+
+CMake uses a "generator" to produce configuration files for use by a variety of build tools, e.g., UNIX makefiles,
+Visual Studio projects. By default a system-specific generator is used by CMake during configuration. (Please
+see [the CMake documentation](https://cmake.org/documentation/) for further information.) However, in many cases there
+is a better choice.
 
 #### CLion / Eclipse / Other
+
 The recommended generator for most unix platforms is 'Makefiles' (default):
 
 ```console
@@ -55,10 +65,12 @@ $ cmake ..
 #### Mac OSX Xcode
 
 Install XCode from the App Store
+
 * You have to run XCode once to get it initialize properly (software agreement).
 * Install the command line tools for xcode - run `xcode-select --install` from terminal
 
-Install the required dependencies through homebrew.   If you use another package manager for your mac feel free to use that.
+Install the required dependencies through homebrew. If you use another package manager for your mac feel free to use
+that.
 
 ```bash
 $ brew install geode
@@ -67,35 +79,33 @@ $ brew install doxygen
 $ brew install cmake
 ```
 
-Follow these steps to build the geode native client.   The recommended code generator is `Xcode`.
+You will need to provide the path to the brew installed OpenSSL headers since macOS already has a system installed
+version but without the required headers.
 
 ```bash
-$ cd <clone>
-$ mkdir build
-$ cd build
-$ cmake .. -G "Xcode" -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_INSTALL_PREFIX=`pwd`/install
-$ cmake --build . --target docs
-$ cmake --build . --target install -j8
+$ cmake .. -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
 ```
 
-At the end of the process the geode native client will be in the  `<clone>/build/install` directory.
-
 #### Windows / Visual Studio
-When running cmake commands on Windows, be sure to use [Visual Studio Native Tools Command Prompt](https://msdn.microsoft.com/en-us/library/f35ctcxw.aspx) so environment variables are set properly.
 
-The recommended generator on Windows is `Visual Studio 15 2017 Win64`:
+For Visual Studio 2017 and newer you only need to specify the correct architecture, toolset and SDK for Windows. To
+build a 64-bit library using the 64 bit toolset version 14.1 with minimum ABI compatibility of 14.16 for minimum Windows
+version 10.0.16299.0 use the following options.
 
 ```console
-$ cmake .. -G "Visual Studio 15 2017 Win64" -Thost=x64
+$ cmake .. -A x64 -Tv141,version=14.16,host=x64 -DCMAKE_SYSTEM_VERSION=10.0.16299.0
 ```
 
-Visual Studio 2019 is also supported. For this generator you must leave off the Win64:
+At a bare minimum you will likely need to specify the architecture, since MSVC still defaults to 32 bit, and the 64 bit
+version of the toolset, because of large object files. The latest toolset version and Windows SDK will likely get picked
+up.
 
 ```console
-$ cmake .. -G "Visual Studio 16 2019" -Thost=x64
+$ cmake .. -A x64 -Thost=x64
 ```
 
 ### Build Parallelism
+
 For faster builds, use optional parallelism parameters in the last build step:
 
 #### Unix
@@ -122,12 +132,16 @@ $ cmake … -DWITH_IPV6=ON …
 
 #### Code Coverage
 
-If building with GCC or Clang you can enable C++ code coverage by adding `-DUSE_CPP_COVERAGE=ON` to the CMake [Generator](#generator) command. 
+If building with GCC or Clang you can enable C++ code coverage by adding `-DUSE_CPP_COVERAGE=ON` to the
+CMake [Generator](#generator) command.
 
 ```console
 $ cmake … -DUSE_CPP_COVERAGE=ON …
 ```
-You can then generate a C++ code coverage report by downloading [lcov](http://ltp.sourceforge.net/coverage/lcov.php).  After acquiring lcov, finish the [Steps to build](#Steps-to-build) section above.  Then, run the tests as described in the [CONTRIBUTING.md](CONTRIBUTING.md). Finally, run the following commands from the `build` directory:
+
+You can then generate a C++ code coverage report by downloading [lcov](http://ltp.sourceforge.net/coverage/lcov.php).
+After acquiring lcov, finish the [Steps to build](#Steps-to-build) section above. Then, run the tests as described in
+the [CONTRIBUTING.md](CONTRIBUTING.md). Finally, run the following commands from the `build` directory:
 
 ```console
 $ lcov --capture --directory . --output-file coverage.info
@@ -137,45 +151,61 @@ $ genhtml coverage.info --output-directory coverage_report
 You can then open the `index.html` file in the `coverage_report` directory using any browser.
 
 #### Clang-Tidy
+
 To enable `clang-tidy`:
 
 ```console
 $ cmake … -DCMAKE_CXX_CLANG_TIDY=clang-tidy …
 ```
+
 To use specific `clang-tidy`:
 
 ```console
 $ cmake … -DCMAKE_CXX_CLANG_TIDY=/path/to/clang-tidy …
 ```
+
 By default `clang-tidy` uses the configuration found in `.clang-tidy`
 To override `clang-tidy` options:
 
 ```console
 $ cmake … -DCMAKE_CXX_CLANG_TIDY=clang-tidy;<options> …
 ```
+
 #### Clang-format
-Individual targets in the build tree have their own dependency of the form `<<targetName>>-clangformat`, which uses the `clang-format` executable, wherever it is found, to format and modified files according to the rules specfied in the .clang-format file.  This is helpful when submitting changes to geode-native, because an improperly formatted file will fail Travis-CI and have to be fixed prior to merging any pull request.  If clang-format is not installed on your system, clangformat targets will not be added to your project files, and geode-native should build normally.  Under some circumstances, however, it may become necessary to disable `clang-format` on a system where it _is_ installed.
+
+Individual targets in the build tree have their own dependency of the form `<<targetName>>-clangformat`, which uses
+the `clang-format` executable, wherever it is found, to format and modified files according to the rules specfied in the
+.clang-format file. This is helpful when submitting changes to geode-native, because an improperly formatted file will
+fail Travis-CI and have to be fixed prior to merging any pull request. If clang-format is not installed on your system,
+clangformat targets will not be added to your project files, and geode-native should build normally. Under some
+circumstances, however, it may become necessary to disable `clang-format` on a system where it _is_ installed.
 
 To disable `clang-format` in the build:
 
 ```
 $ cmake … -DClangFormat_EXECUTABLE='' …
 ```
 
-On the other hand, it may also be desirable to run clang-format on the entire source tree.  This is also easily done via the `all-clangformat` _in a build with clang-format enabled_.  If clang-format has been disabled in the cmake configuration step, as above, the `all-clangformat` target will not exist, and the cmake configuration step will have to be re-run with clang-format enabled.
+On the other hand, it may also be desirable to run clang-format on the entire source tree. This is also easily done via
+the `all-clangformat` _in a build with clang-format enabled_. If clang-format has been disabled in the cmake
+configuration step, as above, the `all-clangformat` target will not exist, and the cmake configuration step will have to
+be re-run with clang-format enabled.
 
 To run clang-format on the entire source tree:
 
 ```
 $ cmake --build . --target all-clangformat
 ```
 
-
 ## Installing
-By default a system-specific location is used by CMake as the destination of the `install` target, e.g., `/usr/local` on UNIX system. To explicitly specify the location in which the Native Client will be installed, add `-DCMAKE_INSTALL_PREFIX=/path/to/installation/destination` to the _initial_ `cmake` execution command.
 
-**Note:** For consistent results, avoid using the "~" (tilde) abbreviation when specifying paths on the CMake command line.
-Interpretation of the symbol varies depending on the option being specified, and on the system or command shell in use.
+By default a system-specific location is used by CMake as the destination of the `install` target, e.g., `/usr/local` on
+UNIX system. To explicitly specify the location in which the Native Client will be installed,
+add `-DCMAKE_INSTALL_PREFIX=/path/to/installation/destination` to the _initial_ `cmake` execution command.
+
+**Note:** For consistent results, avoid using the "~" (tilde) abbreviation when specifying paths on the CMake command
+line. Interpretation of the symbol varies depending on the option being specified, and on the system or command shell in
+use.
 
 Due to limitations in CMake, the documentation must be built as a separate step before installation:
 
@@ -189,49 +219,60 @@ $ cmake --build . --target install
 # Platform-Specific Prerequisites
 
 ## <a id="windows"></a>Windows
+
 * Windows 8.1 64-bit
 * Windows 10 64-bit
 * Windows Server 2012 R2 64-bit
 * Windows Server 2016 64-bit
 * NUnit 2.6.4 (to run clicache tests)
 
 ### Required Tools
+
 * [Visual Studio 2015](https://www.visualstudio.com) or newer
 * .NET 4.5.2 or later
 * Chocolatey
 * [Other dependencies installed via Powershell](packer/windows/install-dependencies.ps1)
 
 ## <a id="linux"></a>Linux
+
 * RHEL/CentOS 6
 * RHEL/CentOS 7
 * SLES 11
 * SLES 12
 
 ### Required Tools
+
 * [GCC 5](https://gcc.gnu.org) or newer
 
 ### Optional Tools
+
 * [Eclipse CDT 8.8](https://eclipse.org/cdt/) or newer
 
 ## <a id="mac-os-x"></a>Mac OS X
+
 * Mac OS X 10.12 (Sierra) or newer
 * Xcode 8.2 or newer
 
 ### Required Tools
+
 * [Xcode](https://developer.apple.com/xcode/download/)
 * Xcode command line developer tools
+
 ```console
 $ xcode-select --install
 ```
 
 ### Optional Tools
+
 * [CMake GUI](https://cmake.org/)
 * [Doxygen GUI](http://ftp.stack.nl/pub/users/dimitri/Doxygen-1.8.11.dmg)
 * [CLion](https://www.jetbrains.com/clion/)
 
 ## <a id="solaris"></a>Solaris
+
 * Solaris 11 SPARC
 * Solaris 11 x86
 
 ### Required Tools
+
 * [Solaris Studio 12.6](http://www.oracle.com/technetwork/server-storage/developerstudio/downloads/index.html) or newer

CMakeLists.txt

@@ -403,3 +403,5 @@ if (USE_RAT)
     COMMENT "Checking source with Apache Rat."
   )
 endif()
+
+#message(FATAL_ERROR "this is a bad PR")