Fix: Build Failing on latest Xcode #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
bbbneo333
reviewed
Jul 22, 2024
| @@ -51,6 +51,19 @@ target 'Boilerplate' do | |||
| end | |||
|
|
|||
| post_install do |installer| | |||
| installer.pods_project.targets.each do |target| | |||
| if target.name == 'Flipper' | |||
There was a problem hiding this comment.
Hey @abhishek310001 - Verified locally and this fix works. But it'd be good to add a comment here on what issue we are trying to fix, and possibly add the link from where this fix was obtained (a link to GH/stackoverflow maybe)?
There was a problem hiding this comment.
Thanks for verifying, will add a comment ASAP.
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: jalantechnologies_boilerplate-react-native |
bbbneo333
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue of build failing on latest Xcode version.
Changes
Tests
Automated test cases added
NA
Manual test cases run
For each manual test case, list the steps to test or reproduce the PR.
NA