-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor config module #120
base: tarun/refactor/frm-18-refactor-config-module
Are you sure you want to change the base?
feat: refactor config module #120
Conversation
This comment has been minimized.
This comment has been minimized.
from modules.logger.logger import Logger | ||
|
||
|
||
class ConfigParser: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please check feedback video and improvise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the latest commit.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Deployment (frm-boilerplate) is available at - https://d3fdb7ec929ae53.preview.platform.jalantechnologies.com |
Minimum allowed line rate is |
Description
Break down the internal config helper into
config_manager
andconfig_parser
to abstract away functionality. Fix various type mismatches and use generic type for the config return value.