Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor config module #120

Open
wants to merge 3 commits into
base: tarun/refactor/frm-18-refactor-config-module
Choose a base branch
from

Conversation

sn1f3rt
Copy link
Contributor

@sn1f3rt sn1f3rt commented Jan 31, 2025

Description

Break down the internal config helper into config_manager and config_parser to abstract away functionality. Fix various type mismatches and use generic type for the config return value.

@sn1f3rt sn1f3rt self-assigned this Jan 31, 2025
@sn1f3rt sn1f3rt added the chore Housekeeping label Jan 31, 2025

This comment has been minimized.

@sn1f3rt sn1f3rt requested review from jjalan and Killg0d January 31, 2025 06:58
from modules.logger.logger import Logger


class ConfigParser:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check feedback video and improvise?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the latest commit.

This comment has been minimized.

This comment has been minimized.

@sn1f3rt sn1f3rt requested a review from jjalan January 31, 2025 11:00
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • No coverage informationNo coverage information (0.00% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.50% Estimated after merge)

Project ID: jalantechnologies_rflask-boilerplate

View in SonarQube

Copy link

Deployment (frm-boilerplate) is available at - https://d3fdb7ec929ae53.preview.platform.jalantechnologies.com

Copy link

Code Coverage

Package Line Rate Health
src.apps.backend 97%
src.apps.backend.bin 70%
src.apps.backend.modules 100%
src.apps.backend.modules.access_token 99%
src.apps.backend.modules.access_token.rest_api 100%
src.apps.backend.modules.account 99%
src.apps.backend.modules.account.internal 98%
src.apps.backend.modules.account.internal.store 97%
src.apps.backend.modules.account.rest_api 100%
src.apps.backend.modules.application 93%
src.apps.backend.modules.common 89%
src.apps.backend.modules.communication 81%
src.apps.backend.modules.communication.internals 48%
src.apps.backend.modules.config 100%
src.apps.backend.modules.config.internals 88%
src.apps.backend.modules.error 85%
src.apps.backend.modules.logger 86%
src.apps.backend.modules.logger.internal 79%
src.apps.backend.modules.otp 100%
src.apps.backend.modules.otp.internal 91%
src.apps.backend.modules.otp.internal.store 97%
src.apps.backend.modules.password_reset_token 100%
src.apps.backend.modules.password_reset_token.internal 97%
src.apps.backend.modules.password_reset_token.internal.store 100%
src.apps.backend.modules.password_reset_token.rest_api 100%
tests 100%
tests.modules 100%
tests.modules.access_token 99%
tests.modules.account 100%
tests.modules.common 90%
tests.modules.config 100%
tests.modules.password_reset_token 100%
Summary 93% (1691 / 1822)

Minimum allowed line rate is 60%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants