Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for profiles that don't have data for all ratings in chess.com #65

Conversation

cnunezre
Copy link
Contributor

@cnunezre cnunezre commented Jun 19, 2024

Fixes #64

  • Adding support for profiles that don't have data for all ratings in chess.com
  • Tested locally in a personal discord server
  • I am not adding unit tests since this implementation might change after #62 is addressed

Fix Screenshot
Screenshot 2024-06-20 at 11 27 43 AM

Copy link
Owner

@jalpp jalpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jalpp jalpp merged commit 4cf2bb9 into jalpp:master Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

profileCC breaks when there is no rating for a user in a specific chess category like bullet
2 participants