-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/sim ln integration #1038
Open
kelvinator07
wants to merge
9
commits into
jamaljsr:master
Choose a base branch
from
kelvinator07:feat/sim-ln-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/sim ln integration #1038
kelvinator07
wants to merge
9
commits into
jamaljsr:master
from
kelvinator07:feat/sim-ln-integration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinator07
force-pushed
the
feat/sim-ln-integration
branch
from
October 29, 2024 21:28
265dd92
to
26c7a93
Compare
@Abdulkbk FYI |
@kelvinator07 Thanks for working on this. I've played with it a bit and just have a little feedback so far on the UX considering the full functionality is not completed yet.
I'm sure I'll have more feedback as this PR progresses but that's what stood out to me on my first pass. |
@jamaljsr Thanks for your feedback. I'll update and revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #829
Replaces #868
Description
This PR implements SimLN into Polar.
SimLN is a simulation tool that can be used to generate realistic payment activity on any lightning network topology. It is intentionally environment-agnostic so that it can be used across many environments - from integration tests to public signets.
Polar provides a set of node configurations and payment activities (such as amount and frequency) to SimLN, which facilitates ongoing payments between the nodes.
To ensure successful payments, there must be an existing channel established between the nodes.
Steps to Test
Activity Designer
menuAdd Activities
Source
andDestination
nodesSTART
buttonScreenshots