Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new rrq offload configuration API. #34

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

plietar
Copy link
Contributor

@plietar plietar commented Nov 13, 2024

rrq 0.7.20 has changed a bit how the offload gets configured. Instead of being a global property that must be configured ahead of time, the path to the offload directory is now set per-controller/worker. The offload threshold size is similar, although for workers it is set through the worker configuration.

rrq 0.7.20 has changed a bit how the offload gets configured. Instead of
being a global property that must be configured ahead of time, the path
to the offload directory is now set per-controller/worker. The offload
threshold size is similar, although for workers it is set through the
worker configuration.
@plietar
Copy link
Contributor Author

plietar commented Nov 13, 2024

This needs mrc-ide/rrq#126

@plietar plietar marked this pull request as ready for review November 18, 2024 15:15
Copy link
Contributor

@EmmaLRussell EmmaLRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Nice simplification!

@david-mears-2
Copy link
Contributor

Can you update the package version in DESCRIPTION to help us if deployment goes funny?

@plietar
Copy link
Contributor Author

plietar commented Nov 20, 2024

Done.

We have a set of files we've been copying around different repos to check this / make easy to bump versions: mrc-ide/orderly2@f0e99db. You might want to add it here as well.

@richfitz richfitz merged commit 5ffd970 into jameel-institute:main Nov 20, 2024
8 checks passed
@plietar plietar deleted the update-rrq branch November 20, 2024 17:00
@david-mears-2
Copy link
Contributor

Thanks @plietar - I've added these scripts now in #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants