Fix: when dragging the slider, the mouse movements get attached to the s... #261
Conversation
…ed to the scroll" This reverts commit ebb58f3.
…e scroll Fix: when dragging the slider, the mouse movements get attached to the scroll Adding `mouseleave` event handler that calls events.up() seems to clear the problem
|
Thanks! I still need to test this. |
|
Sorry about this taking too long, gonna try to test it during the weekend. |
|
@mirovit I tested your PR code. I tried to reproduce the problem that you are trying to solve in this PR, but did not manage to do it. Is this something that is specific to using Select2? Could you provide me info on how to reproduce the problem or put together a demo of it? I'll be happy to merge your patch as soon as I can understand the problem. |
|
@kristerkari I have used it here - http://www.jobtiger.bg/obiavi-za-rabota/?ln=1 But I have applied the fix in the JS, and this is the reason I made the pull request - to be able to upgrade the plugin version, without having to manually add that line of code to the source. If you want to reproduce it, the easiest way is to get a CDN version of the JS and replace the one in the site with the CDN version through the Dev Tools. |
|
@mirovit Alright, thanks. So do you think that this is possible to happen in nanoScroller, or is it related to having Select2 + nanoScroller on the same page? |
When the nanoScroller is created dynamicly within a select2 instance, there is an issue - when you start dragging the slider with the mouse, after releasing it (if it is not at the top or bottom) the mouse movement gets translated as scroll.
To fix it I added an event listener for
mouseleave.Sorry for the first one, I am new new to git and didn't see that I changed the other files. Now I have included only the
.coffeefile that can be compiled to js.