-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] [ci] Added Windows CI for R package #6
Conversation
seeing this:
Seems like that check is stricter on Windows than on Linux |
Things that I see on Appveyor so far:
|
fa6d229
to
92cbf75
Compare
details on the software included in the images we use: |
notes on issues with |
how to remove one item from PATH: https://stackoverflow.com/a/39141462/3986677 to deal with this thing I see on appveyor
|
f911585
to
45adca9
Compare
b60826a
to
9e6aa49
Compare
* [refactor] Cleanup MissingType enum constants * Update tree.cpp Co-authored-by: Alberto Ferreira <[email protected]>
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This PR adds CI support for the R package on Windows. It also bumps up the version of R we test against from 3.6.1 to 3.6.3.
As of this PR, the following
R CMD check
NOTES remain on Windows:note-1
note-2
note-3
note-4
note-1
: not relevant for us, won't actually show up on CRAN and we shouldn't incur the extra time to install those packages. CRAN will have allSuggests
dependencies available.note-2
: only showing up on Windows. Probably some build files not caught by.Rbuildignore
. Can be addressed in a follow-up PR.note-3
: addressed by [R-package] adding routine registration in R package (fixes #1910) microsoft/LightGBM#2911note-4
: Can be addressed in a follow-up PR.