Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LLVM 17 #10

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Support LLVM 17 #10

merged 4 commits into from
Feb 5, 2024

Conversation

SUPERCILEX
Copy link
Contributor

Fixes #8

llvm-plugin/Cargo.toml Outdated Show resolved Hide resolved
@jamesmth
Copy link
Owner

jamesmth commented Feb 2, 2024

I need to release LLVM 17 binaries in the fork https://github.com/jamesmth/llvm-project, so that we can add CI jobs for testing this version on all platforms.

@jamesmth
Copy link
Owner

jamesmth commented Feb 2, 2024

Also, did LLVM 17 add any new API into PassBuilder that would be interesting to add into the crate::PassBuilder type?

@SUPERCILEX
Copy link
Contributor Author

I need to release LLVM 17 binaries in the fork jamesmth/llvm-project, so that we can add CI jobs for testing this version on all platforms.

Sounds good! I think it'll probably take a week or so to see a release from inkwell, so no rush.

Also, did LLVM 17 add any new API into PassBuilder that would be interesting to add into the crate::PassBuilder type?

No clue unfortunately. I think this can be left to future work.

Copy link
Owner

@jamesmth jamesmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now add the following line to test with LLVM 17:

- ["17", "17-0", "v17.0.6-rust-1.75/llvm-lld-17.0.6-rust-1.75-linux.tar.gz"]

Here:

strategy:
matrix:
llvm-version:
- ["10", "10-0", "v10.0.1-rust-1.46/llvm-10.0.1-rust-1.46-linux.tar.gz"]
- ["11", "11-0", "v11.0.1-rust-1.51/llvm-lld-11.0.1-rust-1.51-linux.tar.gz"]
- ["12", "12-0", "v12.0.1-rust-1.55/llvm-lld-12.0.1-rust-1.55-linux.tar.gz"]
- ["13", "13-0", "v13.0.0-rust-1.59/llvm-lld-13.0.0-rust-1.59-linux.tar.gz"]
- ["14", "14-0", "v14.0.6-rust-1.64/llvm-lld-14.0.6-rust-1.64-linux.tar.gz"]
- ["15", "15-0", "v15.0.0-rust-1.65/llvm-lld-15.0.0-rust-1.65-linux.tar.gz"]
- ["16", "16-0", "v16.0.2-rust-1.71/llvm-lld-16.0.2-rust-1.71-linux.tar.gz"]

And this line:

- ["17", "17-0", "1.75", "v17.0.6-rust-1.75/llvm-lld-17.0.6-rust-1.75-linux.tar.gz"]

Here:

strategy:
matrix:
llvm-version:
- ["11", "11-0", "1.51", "v11.0.1-rust-1.51/llvm-lld-11.0.1-rust-1.51-linux.tar.gz"]
- ["12", "12-0", "1.55", "v12.0.1-rust-1.55/llvm-lld-12.0.1-rust-1.55-linux.tar.gz"]
- ["13", "13-0", "1.59", "v13.0.0-rust-1.59/llvm-lld-13.0.0-rust-1.59-linux.tar.gz"]
- ["14", "14-0", "1.64", "v14.0.6-rust-1.64/llvm-lld-14.0.6-rust-1.64-linux.tar.gz"]
- ["15", "15-0", "1.65", "v15.0.0-rust-1.65/llvm-lld-15.0.0-rust-1.65-linux.tar.gz"]
- ["16", "16-0", "nightly-2023-04-29", "v16.0.2-rust-1.71/llvm-lld-16.0.2-rust-1.71-linux.tar.gz"]

(you can probably also replace nightly-2023-04-29 with 1.71 in the last line of this snippet)

Make sure you apply these changes in the files .github/workflows/macos.yml and .github/workflows/windows.yml as well!

Cargo.toml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Copy link
Owner

@jamesmth jamesmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jamesmth jamesmth merged commit 57b018a into jamesmth:master Feb 5, 2024
36 checks passed
@SUPERCILEX
Copy link
Contributor Author

Awesome! Do you know when you'll be able to make a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support llvm 17
2 participants