Remove utils since all iterators were upstreamed

examples/opcode_counter.rs

@@ -4,7 +4,6 @@
 use std::collections::HashMap;
 
 use llvm_plugin::inkwell::values::{FunctionValue, InstructionOpcode};
-use llvm_plugin::utils::InstructionIterator;
 use llvm_plugin::{
     AnalysisKey, FunctionAnalysisManager, LlvmFunctionAnalysis, LlvmFunctionPass, PassBuilder,
     PipelineParsing, PreservedAnalyses,
@@ -57,7 +56,7 @@ impl LlvmFunctionAnalysis for OpcodeCounterAnalysis {
         let mut opcode_map = HashMap::new();
 
         for bb in function.get_basic_blocks() {
-            for instr in InstructionIterator::new(&bb) {
+            for instr in bb.get_instructions() {
                 opcode_map
                     .entry(instr.get_opcode())
                     .and_modify(|e| *e += 1)

examples/static_call_counter.rs

@@ -7,7 +7,6 @@ use either::Either;
 
 use llvm_plugin::inkwell::module::Module;
 use llvm_plugin::inkwell::values::{BasicValueEnum, InstructionOpcode};
-use llvm_plugin::utils::InstructionIterator;
 use llvm_plugin::{
     AnalysisKey, LlvmModuleAnalysis, LlvmModulePass, ModuleAnalysisManager, PassBuilder,
     PipelineParsing, PreservedAnalyses,
@@ -47,7 +46,7 @@ impl LlvmModuleAnalysis for StaticCallCounterAnalysis {
 
         for func in module.get_functions() {
             for bb in func.get_basic_blocks() {
-                for instr in InstructionIterator::new(&bb) {
+                for instr in bb.get_instructions() {
                     if !matches!(instr.get_opcode(), InstructionOpcode::Call) {
                         continue;
                     }

examples/strings.rs

@@ -7,7 +7,6 @@ use llvm_plugin::inkwell::basic_block::BasicBlock;
 use llvm_plugin::inkwell::module::{Linkage, Module};
 use llvm_plugin::inkwell::values::{BasicValueEnum, FunctionValue, GlobalValue};
 use llvm_plugin::inkwell::{AddressSpace, IntPredicate};
-use llvm_plugin::utils::GlobalIterator;
 use llvm_plugin::{
     LlvmModulePass, ModuleAnalysisManager, PassBuilder, PipelineParsing, PreservedAnalyses,
 };
@@ -59,7 +58,7 @@ fn encode_global_strings<'a>(module: &mut Module<'a>) -> Vec<GlobalString<'a>> {
     let mut global_strings = Vec::new();
     let cx = module.get_context();
 
-    for global in GlobalIterator::new(module) {
+    for global in module.get_globals() {
         // ignore external globals
         if matches!(global.get_linkage(), Linkage::External) {
             continue;

llvm-plugin/build.rs

@@ -98,7 +98,7 @@ mod llvm_sys {
     fn locate_llvm_config() -> Option<PathBuf> {
         let prefix = env::var_os(&*ENV_LLVM_PREFIX)
             .map(|p| PathBuf::from(p).join("bin"))
-            .unwrap_or_else(PathBuf::new);
+            .unwrap_or_default();
         for binary_name in llvm_config_binary_names() {
             let binary_name = prefix.join(binary_name);
             match llvm_version(&binary_name) {

llvm-plugin/src/analysis.rs

@@ -125,7 +125,7 @@ impl FunctionAnalysisManager {
             }
 
             Box::into_raw(pass);
-            #[allow(clippy::forget_copy)]
+            #[allow(forgetting_copy_types)]
             std::mem::forget(function);
         }
 

llvm-plugin/src/lib.rs

@@ -117,9 +117,6 @@ pub use pass_manager::*;
 mod pass_builder;
 pub use pass_builder::*;
 
-/// Utilities.
-pub mod utils;
-
 /// Enum specifying whether analyses on an IR unit are not preserved due
 /// to the modification of such unit by a transformation pass.
 #[repr(C)]

llvm-plugin/src/pass_manager.rs

@@ -111,7 +111,7 @@ impl FunctionPassManager {
             let preserve = pass.run_pass(&mut function, &manager);
 
             Box::into_raw(pass);
-            #[allow(clippy::forget_copy)]
+            #[allow(forgetting_copy_types)]
             std::mem::forget(function);
 
             preserve

tests/plugins/plugin5/src/lib.rs

@@ -1,7 +1,6 @@
 use llvm_plugin::inkwell::basic_block::BasicBlock;
 use llvm_plugin::inkwell::module::Module;
 use llvm_plugin::inkwell::values::{FunctionValue, InstructionOpcode, InstructionValue};
-use llvm_plugin::utils::FunctionIterator;
 use llvm_plugin::{
     AnalysisKey, FunctionAnalysisManager, LlvmFunctionAnalysis, LlvmFunctionPass, LlvmModulePass,
     ModuleAnalysisManager, PassBuilder, PipelineParsing, PreservedAnalyses,
@@ -39,7 +38,7 @@ impl LlvmModulePass for Pass1 {
             .get_function_analysis_manager_proxy(&module)
             .get_manager();
 
-        for function in FunctionIterator::new(module) {
+        for function in module.get_functions() {
             let result = manager.get_cached_result::<Ana1>(&function);
             assert!(result.is_none());