Chmanie code mirror #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In prepping this for release, I discovered that it doesn't work on iOS. I didn't troubleshoot the problem, but I did notice that the CodeMirror site says that mobile browsers aren't actively supported. I can't break iOS, so I'm going to postpone integrating CodeMirror for now. |
|
It looks like CodeMirror now supports iOS: codemirror/codemirror5#60 If anyone's interested in updating this patch to work with the latest version of CodeMirror, I'll take it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I already wrote in the comments, here is my pull request for using CodeMirror.