Fix Visibility issues and add tests to prove it #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save BindTargets for each bound property at ready The only work done during change detection is `get_target()`, `set_value()` and `get_value()`
jamie-pate
force-pushed
the
test-ci
branch
2 times, most recently
from
cf4a5c6 to
69fde84
Compare
Confirm that change detection is called properly when binds become visible in the tree Confirm that change detection does not get called for invisible items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a benchmark to be sure our visibility optimizations are as fast as possible
Add github actions CI workflow for: