-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using ACME v2 and possibility of generate wildcard certificates #114
base: master
Are you sure you want to change the base?
Conversation
Awesome, thanks for the update. 👏 The configuration
Changing the order to |
Nice work @asdek 👍🏻 I tried to use this morning, but ran into a problem:
Looks like this is fixed go-acme/lego#562, but I believe you are already using v1.0.1 of lego? |
This only looks to be a problem if you set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracked the problem down to the v01 endpoint being used for Staging/Sandbox.
letsencrypt/client.go
Outdated
) | ||
|
||
const ( | ||
StorageDir = "/etc/letsencrypt" | ||
ProductionApiUri = "https://acme-v01.api.letsencrypt.org/directory" | ||
ProductionApiUri = "https://acme-v02.api.letsencrypt.org/directory" | ||
StagingApiUri = "https://acme-staging.api.letsencrypt.org/directory" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs to be updated to the v02 endpoint https://acme-staging-v02.api.letsencrypt.org/directory
, otherwise, we get the error:
03/07/2018 13:50:27time="2018-07-03T12:50:27Z" level=fatal msg="LetsEncrypt client: Could not create client: directory missing new registration URL"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Fixed
👍 on this one |
bump |
Bump 👍 |
@asdek it is likely that @janeczku abandon this project. There is the way how to make your work to go public. But there is second question. Do you wanna maintain it? (new PRs, new features, bugfixes etc) |
I doubt this will ever be merged considering Rancher has now moved to 2.0 and they don't seem to want to do any sort of development to 1.6 environments. |
This is quite sad, that this project is abandonned. |
@asdek Is it possible to us this in Rancher 1.6 without the Rancher Catalog? I noticed there is a |
I guess I answered my own question, this seems to work 👍 |
I've created instructions for creating new services with the forked version of this repo manually : https://gist.github.com/fridgerator/db607d268f1f99329c8f9449e89abb4f |
Hello,