Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multilingual: let Python choose quote types; don't use f-strings for translations where not necessary #105

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Multilingual: let Python choose quote types; don't use f-strings for translations where not necessary #105

merged 2 commits into from
Jan 1, 2025

Conversation

janezd
Copy link
Owner

@janezd janezd commented Dec 28, 2024 •
edited
Loading

Fixes #98.

  • Do not enforce quote types because they don't matter. Let Python choose them: just call repr to "uneval" a string
  • Don't use f-strings for translations where not necessary.
  • Do not unescape raw string where originals are not raw.

@janezd janezd force-pushed the f-string-different-quotes branch 3 times, most recently from 48160d2 to 7c79760 Compare January 1, 2025 11:37
@janezd janezd changed the title Allow different quotes in f-string translations; don't unnecessarily use f-strings for translations Allow different quotes in f-string translations; don't use f-strings for translations when not necessary Jan 1, 2025
@janezd janezd changed the title Allow different quotes in f-string translations; don't use f-strings for translations when not necessary Multilingual: let Python choose quote types; don't use f-strings for translations where not necessary Jan 1, 2025
@janezd janezd force-pushed the f-string-different-quotes branch 2 times, most recently from f9d8871 to 28ff10e Compare January 1, 2025 17:29
@janezd janezd force-pushed the f-string-different-quotes branch from 28ff10e to bd7d785 Compare January 1, 2025 19:43
@janezd janezd merged commit 16071ea into master Jan 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary strict multilingual mode
1 participant
@janezd