Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version flag #160

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Add version flag #160

merged 3 commits into from
Jan 29, 2025

Conversation

tonidy
Copy link
Contributor

@tonidy tonidy commented Jan 29, 2025

See #158

@tonidy tonidy mentioned this pull request Jan 29, 2025
@tonidy
Copy link
Contributor Author

tonidy commented Jan 29, 2025

Oops, the test failed. I’ll fix it soon! 😅

main.go Show resolved Hide resolved
main.go Show resolved Hide resolved
Copy link
Owner

@janpfeifer janpfeifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super high quality @tonidy , thank you so much!!

I made a couple of very minor changes request, I hope you are ok, otherwise looks good to me!

internal/version/version.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
@tonidy tonidy requested a review from janpfeifer January 29, 2025 07:23
@janpfeifer
Copy link
Owner

Very neat. Merging, and this week I'll cut another release -- after I refactor the install() and extraLog() functionality.

@janpfeifer janpfeifer merged commit 1724d57 into janpfeifer:main Jan 29, 2025
1 check passed
@tonidy tonidy deleted the version-flag branch January 29, 2025 08:33
@tonidy
Copy link
Contributor Author

tonidy commented Jan 29, 2025

Noted, thanks @janpfeifer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants