Fix: Form submission #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oseasmoran73
commented
Oct 12, 2024
| Save | ||
| </Button> | ||
| </DialogActions> | ||
| <form onSubmit={() => handleUpdateProfile(profile.id)}> |
There was a problem hiding this comment.
Removed required on all textfields
januschung
reviewed
Oct 13, 2024
| defaultValue={jobApplication.salaryRange} | ||
| /> | ||
| <TextField | ||
| id="salaryRange" |
There was a problem hiding this comment.
Good call to make salary range not a hard requirement
januschung
reviewed
Oct 13, 2024
| </LocalizationProvider> | ||
|
|
||
| <TextField | ||
| required | ||
| id="description" |
januschung
reviewed
Oct 13, 2024
| /> | ||
|
|
||
| <DialogContent /> | ||
| <FormControl sx={{ minWidth: 120 }} variant="standard" size="small"> | ||
| <InputLabel id="status-label">Status</InputLabel> | ||
| <Select | ||
| disabled={isNew} |
There was a problem hiding this comment.
um....now I see what you meant by setting it default do open. I think this makes over 90% of the use case. I like that.
januschung
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Thanks @oseasmoran73 for testing it and making the improvement. Great decision!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following:
requiredbeing enabled, there was not a form controller to handle the request. See new outputStatusshould be defaulted to Open and disabled Bug: Adding a job application should default to open #23