-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fontFamily(): allow string value for font-family attribute #121
base: master
Are you sure you want to change the base?
Conversation
@japgolly, it looks like, there are an issues with travis-ci build, not related to this commit:
|
I've suddenly found very simple workaround in docs:
Close this PR? |
@helllamer I’ve been doing this to use default/local fonts:
It’s ugly to have to use the |
@dneades Yes, thanks. It looks like, |
@helllamer I hadn’t known that |
@dneades Thanks for response. I agree, using Will wait for @japgolly 's opinion. |
Observed another possible-dangerous situation with using
Possible solution is to implement attr constructor with like that:
Such method will force |
Sorry for the delay. Varargs seems like a good and reasonable way to go |
Currently, it is
notpossible to use font-faces from external CSS-files:fontFamily.apply()
allow onlyFontFace
instances.This commit allows to specify raw
font-family
string value, making possible to use non-inline fonts faces.