Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check variables existence #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

check variables existence #116

wants to merge 2 commits into from

Conversation

emmanuelgautier
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5a3ac24 on emmanuelgautier:variables-existence into b30ac84 on jaredhanson:master.

@@ -51,6 +51,8 @@ module.exports = function token(server, options) {
if (!server) { throw new TypeError('oauth2orize.token middleware requires a server argument'); }

return function token(req, res, next) {
if (!req.body) { return next(new Error('OAuth2orize requires body parsing. Did you forget app.use(express.bodyParser())?')); }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

express does not bundle bodyParser any more. See http://expressjs.com/4x/api.html#req.body for details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only take error message in other file in this project. Effectivly,
errors messages and express example are outdated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. But this error message should probably be up to date before merging.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c6b91a5 on emmanuelgautier:variables-existence into b30ac84 on jaredhanson:master.

@emmanuelgautier
Copy link
Contributor Author

@tellnes, errors messages are updated in this request #117 . Tell me if you find another

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants