Wrap error for informative messages.

jaredhanson · Apr 28, 2012 · 3901b76 · 3901b76
1 parent c18ed12
commit 3901b76
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/passport-tumblr/strategy.js b/lib/passport-tumblr/strategy.js
@@ -2,7 +2,8 @@
  * Module dependencies.
  */
 var util = require('util')
-  , OAuthStrategy = require('passport-oauth').OAuthStrategy;
+  , OAuthStrategy = require('passport-oauth').OAuthStrategy
+  , InternalOAuthError = require('passport-oauth').InternalOAuthError;
 
 
 /**
@@ -70,7 +71,7 @@ util.inherits(Strategy, OAuthStrategy);
  */
 Strategy.prototype.userProfile = function(token, tokenSecret, params, done) {
   this._oauth.get('http://api.tumblr.com/v2/user/info', token, tokenSecret, function (err, body, res) {
-    if (err) { return done(err); }
+    if (err) { return done(new InternalOAuthError('failed to fetch user profile', err)); }
 
     try {
       var json = JSON.parse(body);

diff --git a/test/strategy-test.js b/test/strategy-test.js
@@ -124,6 +124,9 @@ vows.describe('TumblrStrategy').addBatch({
       'should error' : function(err, req) {
         assert.isNotNull(err);
       },
+      'should wrap error in InternalOAuthError' : function(err, req) {
+        assert.equal(err.constructor.name, 'InternalOAuthError');
+      },
       'should not load profile' : function(err, profile) {
         assert.isUndefined(profile);
       },