Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make typings compatible with v19 #4012

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make typings compatible with v19 #4012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/formik/src/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,9 +279,9 @@ export interface SharedRenderProps<T> {
}

export type GenericFieldHTMLAttributes =
| JSX.IntrinsicElements['input']
| JSX.IntrinsicElements['select']
| JSX.IntrinsicElements['textarea'];
| React.JSX.IntrinsicElements['input']
| React.JSX.IntrinsicElements['select']
| React.JSX.IntrinsicElements['textarea'];

/** Field metadata */
export interface FieldMetaProps<Value> {
Expand Down
2 changes: 1 addition & 1 deletion website/src/components/Container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';
import cn from 'classnames';
import { HTMLProps } from 'react';

export const Container: React.FC<JSX.IntrinsicElements['div']> = ({
export const Container: React.FC<React.JSX.IntrinsicElements['div']> = ({
className,
...props
}) => {
Expand Down
2 changes: 1 addition & 1 deletion website/src/components/FormiumLogo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react';

export const FormiumLogo: React.FC<JSX.IntrinsicElements['svg']> = props => {
export const FormiumLogo: React.FC<React.JSX.IntrinsicElements['svg']> = props => {
return (
<svg
width={'101px'}
Expand Down
2 changes: 1 addition & 1 deletion website/src/components/forwardRefWithAs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export function forwardRefWithAs<Props, ComponentType extends As>(
Test components to make sure our dynamic As prop components work as intended
type PopupProps = {
lol: string;
children?: React.ReactNode | ((value?: number) => JSX.Element);
children?: React.ReactNode | ((value?: number) => React.JSX.Element);
};
export const Popup = forwardRefWithAs<PopupProps, 'input'>(
({ as: Comp = 'input', lol, className, children, ...props }, ref) => {
Expand Down