-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add digest authorization and TCP protocol #32
base: master
Are you sure you want to change the base?
Conversation
alexgor1
commented
Jan 4, 2024
- add digest authorization,
- add support of tcp protocol,
- add support of empty Contact header in message,
- add support of tcp protocol, - add support of empty Contact header in message,
Hi Alex, can you please update the go.sum file? |
updated |
Looks good to me overall. Is there any chance I could persuade you to vendor the HTTP digest code? What it's doing is simple enough to not merit a dependency. I'd rather just vendor the needed code in this project, and add a copyright header to the tops of the file(s) to credit the original author(s). |
It's your project and it's up to you how to include changes to it, so you can vendor digest code of course. As for me i don't like to duplicate existed code which has already been tested. Moreover it's much harder to maintain it and keep up to date. For example last update to digest project on github dated 3 months ago. Anyway i need authorization functionality for SIP stack and if you want to add it into your code and maintain it then it can work for me I guess. I've just offered simplest and clear solution which i use in my fork. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TCP support should be implemented in a way that complies with the RFC