Add hide dependencies to result menu #5046
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RensDofferhoff
changed the title
boutinb
requested changes
Mar 30, 2023
RensDofferhoff
force-pushed
the
hideDependencies
branch
from
998f407 to
219e98b
Compare
|
Your fix does not work correctly. If I open a Descriptive analysis, I click on 'Show dependencies' for the Descriptives Statistics table, then Hide dependencies. Afterwards I select one variable, then the Variables & Split get the green broder:
|
JorisGoosen
requested changes
Jun 20, 2023
There was a problem hiding this comment.
"Hide Dependencies" should only be shown for the one that is actually showing dependencies...
See screenshot with two analyses or two jaspObjects:
The shown dependencies are for "Descriptive Statistics" table in both cases.
And perhaps I want to see more dependencies for more objects?
Now I have to click twice...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/jasp-stats/INTERNAL-jasp/issues/2254
A lot of changes for something so small.