Ship XQuartz libraries #5346
Merged
Ship XQuartz libraries #5346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested it on Mac ARM & Intel. |
|
Ive turned on nightly builds so I can test it like that. |
Load XQuartz package Copy only the useful libraries install_name_tool the libraries and the modules/R_X11.so and R_de.so files Sign them
The modules need to be updated first (for jaspBase). I just did. I'm starting the nightly again. |
|
Why did you not mention the changes to jaspBase here then? |
Yes I should have done. I thought jaspBase was already updated in the shipXQuartz branch |
JorisGoosen
approved these changes
Dec 12, 2023
|
Very nice! |
JorisGoosen
pushed a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/jasp-stats/jasp-test-release/issues/2467
Load XQuartz package
Copy only the useful libraries
install_name_tool the libraries and the modules/R_X11.so and R_de.so files
Sign them