Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BFF #6

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Update BFF #6

merged 7 commits into from
Nov 18, 2024

Conversation

FBartos
Copy link
Contributor

@FBartos FBartos commented Oct 24, 2024

  • Update description and README. Changes displayed name to "Bayes Factor Functions". The BFF abbreviation is not much telling so this makes the module a bit more accessible.
  • Adds basic documentation for the methodology.
  • Disables Priors and Posterior plots as they are still not implemented.
  • Updates renv.

fixes: https://github.com/jasp-stats/jasp-test-release/issues/2747
fixes: https://github.com/jasp-stats/jasp-test-release/issues/2743

@FBartos FBartos marked this pull request as ready for review November 18, 2024 09:52
@FBartos FBartos requested a review from boutinb November 18, 2024 09:52
@boutinb boutinb merged commit 146b28e into jasp-stats:master Nov 18, 2024
1 check passed
@@ -4,16 +4,17 @@ import JASP.Module 1.0
Description
{
name : "jaspBFF"
title : qsTr("BFF (beta)")
title : qsTr("Bayes Factor Functions")
Copy link
Contributor

@shun2wang shun2wang Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should still with "beta" tag isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sending it for testing to the A&M people for whom I developed it. If they are happy with it I would keep it without the beta tag.
(also, it gets way too long in the top banner)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants