Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jaspColumn #125

Merged
merged 2 commits into from
Nov 9, 2023
Merged

use jaspColumn #125

merged 2 commits into from
Nov 9, 2023

Conversation

JorisGoosen
Copy link
Contributor

Uses jasp and jaspBase with changes from
jasp-stats/jaspBase#138
jasp-stats/jasp-desktop#5302

.setColumnDataAsScale etc shouldnt be used by analyses (anymore)

Uses jasp and jaspBase with changes from
jasp-stats/jaspBase#138
jasp-stats/jasp-desktop#5302

.setColumnDataAsScale etc shouldnt be used by analyses (anymore)
Copy link
Member

@Kucharssim Kucharssim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! However I get an error, see the code comment

ordinal=jaspResults[['sampleColumn']]$setOrdinal(sample),
jaspResults[['sampleColumn']]$setNominal(sample))

if(!didItWork)
Copy link
Member

@Kucharssim Kucharssim Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get

This analysis terminated unexpectedly.

Error in !didItWork: invalid argument type

(suggesting that $set**** returns NULL?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cause you first need those PRs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which are "those"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I am an idiot, you linked them already here. oops 😅

Copy link
Member

@Kucharssim Kucharssim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this does the job indeed!

@boutinb boutinb merged commit dcd004c into master Nov 9, 2023
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants