Add structural invariance and meanstructure identification options #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliuspfadt
force-pushed
the
interceptOption
branch
3 times, most recently
from
330ce27 to
a596472
Compare
Kucharssim
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
The unit tests were already failing before hand, but the failures are in EFA/PCA; the ones for CFA all pass, so it should be good to merge (and update the tests in a different PR).
Otherwise looks good, it seems to work. Just a little code suggestion, fee free to merge after fixing it
R/confirmatoryfactoranalysis.R
Outdated
Comment on lines
217
to
239
| # cfaResult[["lav"]] <- try(lavaan::lavaan( | ||
| # model = mod, | ||
| # data = dataset, | ||
| # group = grp, | ||
| # group.equal = geq, | ||
| # meanstructure = options$meanStructure, | ||
| # se = cfaResult[["spec"]]$se, | ||
| # std.lv = options$modelIdentification == "factorVariance", | ||
| # auto.fix.first = options$modelIdentification == "markerVariable", | ||
| # orthogonal = options$factorsUncorrelated, | ||
| # effect.coding = ifelse(options$modelIdentification == "effectsCoding", "loadings", FALSE), | ||
| # int.ov.free = TRUE, | ||
| # int.lv.free = FALSE, | ||
| # auto.fix.single = TRUE, | ||
| # auto.var = TRUE, | ||
| # auto.cov.lv.x = TRUE, | ||
| # auto.th = TRUE, | ||
| # auto.delta = TRUE, | ||
| # auto.cov.y = TRUE, | ||
| # mimic = options$packageMimiced, | ||
| # estimator = estimator, | ||
| # missing = ifelse(options$naAction == "twoStageRobust", "robust.two.stage", | ||
| # ifelse(options$naAction == "twoStage", "two.stage", options$naAction)) |
|
I think the tests fail because of yet another change in |
juliuspfadt
force-pushed
the
interceptOption
branch
from
a596472 to
350ec6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
structural invariance:
fixes jasp-stats/jasp-issues#2378
meanstructure:
fixes jasp-stats/jasp-issues#2223