Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covariance matrix input #239

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

juliuspfadt
Copy link
Collaborator

@juliuspfadt juliuspfadt commented Oct 15, 2024

@juliuspfadt juliuspfadt force-pushed the corMatInput branch 2 times, most recently from 3f023f7 to 795f339 Compare October 16, 2024 08:04
@juliuspfadt juliuspfadt requested a review from FBartos October 16, 2024 08:05
@juliuspfadt juliuspfadt force-pushed the corMatInput branch 2 times, most recently from 18b4946 to 1095830 Compare October 16, 2024 08:35
@FBartos
Copy link
Contributor

FBartos commented Oct 16, 2024

  • image
    (I assume a different message should be there? :)

  • image
    (this could have an upper bound based on the number of selected variables?)

  • image
    (similar here?)

  • [ ]
    image
    (not sure about this one)

  • [ ]
    image
    (also with some other methods)

@juliuspfadt
Copy link
Collaborator Author

juliuspfadt commented Oct 16, 2024

I changed the code to have a better check, this is all mostly related to loading a data matrix instead of a covariance matrix. You mind checking with a cov matrix?

@juliuspfadt
Copy link
Collaborator Author

juliuspfadt commented Oct 16, 2024

I think the message with the eigenvalue is a bit tricky...
fixed it

@FBartos
Copy link
Contributor

FBartos commented Oct 16, 2024

I think the error message is a bit too much on an empty selection :)
image

also, I get it even if I put my dataset in (which is a cov matrix computed in R:
test_cormat.csv

Copy link
Contributor

@FBartos FBartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copilot says it's good to go

@juliuspfadt juliuspfadt merged commit 7c9a3ba into jasp-stats:master Oct 16, 2024
3 of 5 checks passed
@juliuspfadt juliuspfadt deleted the corMatInput branch October 16, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Use correlation matrix as input
2 participants