Fix test release issues jaspFactor #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliuspfadt
requested review from
FBartos and
vandenman
and removed request for
FBartos
juliuspfadt
force-pushed
the
fixTestRelease
branch
from
6546375 to
9236281
Compare
vandenman
approved these changes
Nov 25, 2024
|
This fixes the psd issue, but was they really no way to make it work for non psd data? If not this is fine, if yes we may want to create a new issue. |
|
what do you mean with work for non-psd data? I assume the issue is that somewhere down the line the matrix is inverted, and that does not work for non-psd matrices. How would we fix that? |
|
Can this PR be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/jasp-stats/jasp-test-release/issues/2740
fixes https://github.com/jasp-stats/jasp-test-release/issues/2741