Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Contingency Table #217

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Fix Contingency Table #217

merged 5 commits into from
Nov 8, 2024

Conversation

FBartos
Copy link
Contributor

@FBartos FBartos commented Oct 29, 2024

fixes: jasp-stats/jasp-issues#80

Allows to:

  • Hide/show table margins
  • Toggle on/off the observed frequencies

@FBartos FBartos requested a review from koenderks October 29, 2024 09:50
@FBartos
Copy link
Contributor Author

FBartos commented Oct 29, 2024

https://www.ebay.nl/sch/i.html?_nkw=red+bull+koelkast&_sop=12
@EJWagenmakers

apparently there was a "TRUE" placeholder for an empty column (this can now be skipped)
@FBartos FBartos requested a review from kylelang October 31, 2024 09:54
Copy link
Contributor

@koenderks koenderks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is it useful to put a note under the table when only the observed or expected counts are shown, indicating what they are? This is relevant for any of the 'cells' options.
  2. The 'table margin' option does not have a header? Is there a better place for this. Maybe header "Table" and option name "show totals" or something? I'm not sure

.Rprofile Show resolved Hide resolved
renv/.gitignore Show resolved Hide resolved
renv/activate.R Show resolved Hide resolved
@koenderks
Copy link
Contributor

Also, do you need to update a help file?

@FBartos
Copy link
Contributor Author

FBartos commented Nov 8, 2024

the help file does not exist :D

@FBartos FBartos removed the request for review from kylelang November 8, 2024 08:56
@FBartos FBartos requested a review from koenderks November 8, 2024 10:56
@FBartos FBartos merged commit 00977e1 into jasp-stats:master Nov 8, 2024
5 checks passed
@FBartos FBartos deleted the release-fixes branch November 8, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide observed cell counts in contingency tables when checkbox is cleared
2 participants