-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initiating enter sequence as 0 success 0 failures for prior prediction table #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.tablePredictions2LS now assumes 0 successes and 0 failures in case no data sequence is specified, so the analysis does not crash.
FBartos
reviewed
Oct 27, 2024
Deleting the length > 0 line for sequence/variable initiates "Enter sequence" and "Select variable" as 0 successes, 0 failures.
Nice, it solves the issue quite convinietly. I did not see any new bugs, but I noticed a couple of additional inconsistencies, could you also address those? Screenshot1:
Screenshot2:
Maybe you could quickly check the Binomial Estimation whether you see something there too. |
1) Prior prediction table remains empty until data is specified. 2) Updating table does not show 1 observation anymore, in case no data is specified. (Binomial testing & estimation) 3) Footnotes that ask you to specify the success and failure key are displayed again in case a sequence is specified but not the keys. (Binomial testing & estimation)
1) Empty figures for sequential analysis in case no data is specified (Binomial Estimation). 2) If no data is specified, prior prediction table and plots remain empty, while posterior prediction table and plots do not (Binomial Testing).
FBartos
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Predictions table in the Prior Predictive Performance section now has no rows if no data is specified.
FBartos
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.tablePredictions2LS now assumes 0 successes and 0 failures in case no data sequence is specified, so the analysis does not crash.
fixes: https://github.com/jasp-stats/INTERNAL-jasp/issues/2657