Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiating enter sequence as 0 success 0 failures for prior prediction table #226

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

jvli4n
Copy link
Contributor

@jvli4n jvli4n commented Oct 27, 2024

.tablePredictions2LS now assumes 0 successes and 0 failures in case no data sequence is specified, so the analysis does not crash.

fixes: https://github.com/jasp-stats/INTERNAL-jasp/issues/2657

.tablePredictions2LS now assumes 0 successes and 0 failures in case no data sequence is specified, so the analysis does not crash.
@FBartos FBartos self-requested a review October 27, 2024 09:41
R/LSbinomialtesting.R Outdated Show resolved Hide resolved
Deleting the length > 0 line for sequence/variable initiates "Enter sequence" and "Select variable" as 0 successes, 0 failures.
@FBartos
Copy link
Collaborator

FBartos commented Oct 28, 2024

Nice, it solves the issue quite convinietly. I did not see any new bugs, but I noticed a couple of additional inconsistencies, could you also address those?

Screenshot1:

  • Prior Predictive Performance: Predictions Table --- It's arguable how good is a prediction from hypotheses without any data, I think the table should be empty (i.e., correspond to the empty figure - you can add a return statement after the table is initialized)
  • Sequential Analysis: Updating Table --- Now incorrectly states "1 Observation"

image

Screenshot2:

  • Posterior Predictions: The tables are generated while the Figure is empty. I think the correct behavior is having the figure output too as prior = posterior, and prior predictions = posterior predictions (I think there is a switch in the code that creates empty dataset to generate those figures in the same functions if type = "prior")

image

Maybe you could quickly check the Binomial Estimation whether you see something there too.

1) Prior prediction table remains empty until data is specified.

2) Updating table does not show 1 observation anymore, in case no data is specified. (Binomial testing & estimation)

3) Footnotes that ask you to specify the success and failure key are displayed again in case a sequence is specified but not the keys. (Binomial testing & estimation)
1) Empty figures for sequential analysis in case no data is specified (Binomial Estimation).

2) If no data is specified, prior prediction table and plots remain empty, while posterior prediction table and plots do not (Binomial Testing).
@jvli4n jvli4n requested a review from FBartos November 4, 2024 16:45
Copy link
Collaborator

@FBartos FBartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks and the results are now consistent. The only very minor nitpic is that in the Prior Predictive Performance Section, the Predictions table should have no rows when no data are specified.

image

Predictions table in the Prior Predictive Performance section now has no rows if no data is specified.
@jvli4n jvli4n requested a review from FBartos November 5, 2024 09:44
@FBartos FBartos merged commit 4428f31 into jasp-stats:master Nov 5, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants