Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release fixes for descriptive stats #63

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

Kucharssim
Copy link
Member

fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/2410

I think there is no real reason not to draw the rugs even for discrete data, if the user wishes to do that...

I am not sure about the scaling of the plot; tbh a lot of plots in the module seem to me as unnecessarily gigantic, was that a deliberate choice, @JTPetter?

@Kucharssim Kucharssim requested a review from JTPetter November 17, 2023 09:53
@JTPetter
Copy link
Collaborator

@Kucharssim Okay, I didn't see a purpose for rugs for a barplot but sure, if anyone wants it :)

With regard to the plot sizes, it was a deliberate choice for many plots, yes. There are a lot of annotations and other layers over most plots, so I used the geom_fixed coordinate system, so I have more control over where everything is placed. However, with geom_fixed the plots can get really big if there are a lot of data. This is mostly relevant for the dotplot, which will otherwise dynamically change the dot sizes, which looks really bad with small numbers of dots. I currently don't have a better idea how to handle this...

@Kucharssim Kucharssim merged commit f564dfd into jasp-stats:master Nov 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants