Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error handling for loeading fitted models #202

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

FBartos
Copy link
Collaborator

@FBartos FBartos commented Oct 19, 2023

@FBartos FBartos requested a review from koenderks October 19, 2023 12:48
if (jaspBase::isTryError(fit) && grepl("cannot open the connection", fit))
.quitAnalysis(gettext("The specified path does not lead to an existing file."))
if (jaspBase::isTryError(fit))
.quitAnalysis(fit)
Copy link
Contributor

@koenderks koenderks Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this line instead of .quitAnalysis(fit)?

.quitAnalysis(gettextf("An error occurred while reading the model file: %1$s", jaspBase:::.extractErrorMessage(fit)))

@FBartos FBartos merged commit f41e350 into jasp-stats:master Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants